Bug 123107 - [iOS] Upstream JSLock changes
Summary: [iOS] Upstream JSLock changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 11:14 PDT by Daniel Bates
Modified: 2013-10-22 13:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.94 KB, patch)
2013-10-21 11:23 PDT, Daniel Bates 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-10-21 11:14:22 PDT 
Add support to hold a spin lock when acquiring and releasing locks. Additionally, implement support to optionally release all locks unconditionally as some client (e.g. Mobile Safari) may require this behavior. Currently, we only support releasing all locks conditionally.
Comment 1 Daniel Bates 2013-10-21 11:23:06 PDT 
Created attachment 214754 [details]
Patch
Comment 2 Daniel Bates 2013-10-21 11:25:12 PDT 
See <rdar://problem/14171014> for the reasoning behind requiring a spin lock when acquiring or releasing all locks.
Comment 3 Daniel Bates 2013-10-21 11:27:00 PDT 
See <rdar://problem/11231897> for details on implementing support to release all locks unconditionally.
Comment 4 Geoffrey Garen 2013-10-21 11:37:44 PDT 
Comment on attachment 214754 [details]
Patch

I am so ashamed of this code :(.
Comment 5 Daniel Bates 2013-10-22 13:38:58 PDT 
Committed r157809: <http://trac.webkit.org/changeset/157809>