Bug 123106 - Remote Layer Tree: Backing store should take contentsScale into account
Summary: Remote Layer Tree: Backing store should take contentsScale into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 11:12 PDT by Tim Horton
Modified: 2013-10-21 13:15 PDT (History)
2 users (show)

See Also:


Attachments
patch (9.91 KB, patch)
2013-10-21 11:44 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-21 11:12:18 PDT
We should scale up our backing store (and repaints, etc.) to match the layer's contentsScale.
Comment 1 Tim Horton 2013-10-21 11:44:21 PDT
Created attachment 214759 [details]
patch
Comment 2 Simon Fraser (smfr) 2013-10-21 11:53:47 PDT
Comment on attachment 214759 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214759&action=review

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.h:59
> +    WebCore::IntRect flipRectForCoordinateSystem(const WebCore::IntRect) const;

"for coördinate system" sounds a bit weird. Maybe "mapToContentCoordinates" or something?
Comment 3 Tim Horton 2013-10-21 13:15:12 PDT
http://trac.webkit.org/changeset/157728