Bug 123083 – Use PassRef for StyleSheetContents.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Andreas Kling]

Use PassRef for StyleSheetContents.

[Andreas Kling]

Created attachment 214697 [details]
Patch

[Build Bot]

Comment on attachment 214697 [details]
Patch

Attachment 214697 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/6798029

[Build Bot]

Comment on attachment 214697 [details]
Patch

Attachment 214697 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/7448037

New failing tests:
fast/dom/StyleSheet/detached-style-2.html

[Build Bot]

Created attachment 214699 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Andreas Kling]

Created attachment 214700 [details]
Patch v2

[Antti Koivisto]

Comment on attachment 214700 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=214700&action=review

> Source/WebCore/css/CSSStyleSheet.h:51
> -    static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>, CSSImportRule* ownerRule = 0);
> -    static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>, Node* ownerNode);
> +    static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>, CSSImportRule* ownerRule = 0);
> +    static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>, Node* ownerNode);

Why not PassRef return?

> Source/WebCore/css/CSSStyleSheet.h:114
> -    StyleSheetContents* contents() const { return m_contents.get(); }
> +    StyleSheetContents* contents() { return &m_contents.get(); }

Reference?

[Build Bot]

Comment on attachment 214700 [details]
Patch v2

Attachment 214700 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/7628027

[Andreas Kling]

Created attachment 214703 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 214703 [details]
Patch for landing

Clearing flags on attachment: 214703

Committed r157702: <http://trac.webkit.org/changeset/157702>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.