Bug 123079 - Simplify TempRegisterSet - it no longer needs to be convertible to a POD since it's no longer going to be a member of a union
Summary: Simplify TempRegisterSet - it no longer needs to be convertible to a POD sinc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 123076
  Show dependency tree / graph
 
Reported: 2013-10-19 21:35 PDT by Filip Pizlo
Modified: 2013-10-19 22:39 PDT (History)
9 users (show)

See Also:

Attachments
the patch (3.00 KB, patch)
2013-10-19 21:36 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-19 21:35:22 PDT 
A long long time ago, when TempRegisterSet was called RegisterSet and the DFG and baseline JIT had separate codepaths for inline caching, the RegisterSet was stored in a union in StructureStubInfo and so had to have a POD version of itself.

None of that is true anymore, so the POD support is just superfluous.
Comment 1 Filip Pizlo 2013-10-19 21:36:20 PDT 
Created attachment 214689 [details]
the patch
Comment 2 Geoffrey Garen 2013-10-19 22:35:12 PDT 
Comment on attachment 214689 [details]
the patch

R=ME
Comment 3 Filip Pizlo 2013-10-19 22:39:47 PDT 
Landed in http://trac.webkit.org/changeset/157696