Bug 123073 - Adding test case for text-decoration property state change on applying different command
Summary: Adding test case for text-decoration property state change on applying differ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-19 16:05 PDT by Santosh Mahto
Modified: 2013-10-19 17:23 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.56 KB, patch)
2013-10-19 16:09 PDT, Santosh Mahto
no flags Details | Formatted Diff | Diff
patch for landing (7.67 KB, patch)
2013-10-19 16:45 PDT, Santosh Mahto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santosh Mahto 2013-10-19 16:05:17 PDT
This test case verify text-decoration property state on element after applying editing commands related to text-decoration.
Comment 1 Santosh Mahto 2013-10-19 16:09:27 PDT
Created attachment 214679 [details]
Patch
Comment 2 Ryosuke Niwa 2013-10-19 16:32:01 PDT
Comment on attachment 214679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214679&action=review

> LayoutTests/editing/style/text-decoration-state-change.html:39
> +    var e = document.getElementById('e');
> +    var s = window.getSelection();
> +    var r = document.createRange();
> +    r.setStart(e, 0);
> +    r.setEnd(e, 1);
> +    e.focus();
> +    s.removeAllRanges();
> +    s.addRange(r);

Please don't use one letter variables.
Comment 3 Santosh Mahto 2013-10-19 16:45:00 PDT
Created attachment 214681 [details]
patch for landing
Comment 4 WebKit Commit Bot 2013-10-19 17:23:01 PDT
Comment on attachment 214681 [details]
patch for landing

Clearing flags on attachment: 214681

Committed r157689: <http://trac.webkit.org/changeset/157689>
Comment 5 WebKit Commit Bot 2013-10-19 17:23:03 PDT
All reviewed patches have been landed.  Closing bug.