123065 – [Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime

Bug 123065 - [Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime

Summary: [Cocoa] Remove some indirection that was only necessary for supporting the le...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit2 (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	mitz

URL:
Keywords:

Depends on:	124850
Blocks:
	Show dependency tree / graph

Reported:	2013-10-19 12:31 PDT by mitz
Modified:	2013-11-25 15:47 PST (History)
CC List:	1 user (show)

See Also:

Attachments
Remove private _data ivars from interfaces (25.93 KB, patch) 2013-10-19 12:45 PDT, mitz	sam: review+	Details \| Formatted Diff \| Diff
Remove private _data ivars from interfaces (30.41 KB, patch) 2013-11-25 14:29 PST, mitz	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description mitz 2013-10-19 12:31:51 PDT

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime

Comment 1 mitz 2013-10-19 12:45:18 PDT

Created attachment 214660 [details]
Remove private _data ivars from interfaces

Comment 2 Sam Weinig 2013-10-19 13:15:19 PDT

Comment on attachment 214660 [details]
Remove private _data ivars from interfaces

Nice. r=me.

Comment 3 mitz 2013-10-19 13:16:53 PDT

Landed in <http://trac.webkit.org/r157676>.

Comment 4 Alexey Proskuryakov 2013-10-19 13:41:31 PDT

This broke 32-bit build, <http://build.webkit.org/builders/Apple%20MountainLion%20Release%20(32-bit%20Build)/builds/4983/steps/compile-webkit/logs/stdio/text>

Comment 5 mitz 2013-10-19 13:43:06 PDT

(In reply to comment #4)
> This broke 32-bit build, <http://build.webkit.org/builders/Apple%20MountainLion%20Release%20(32-bit%20Build)/builds/4983/steps/compile-webkit/logs/stdio/text>

I’m on it.

Comment 6 mitz 2013-10-19 14:34:56 PDT

I reverted everything in r157681. I can attempt this again when I have a 32-bit build.

Comment 7 mitz 2013-11-25 12:14:59 PST

Going to try something like this again after bug 124850 is fixed.

Comment 8 mitz 2013-11-25 14:29:28 PST

Created attachment 217832 [details]
Remove private _data ivars from interfaces

Comment 9 WebKit Commit Bot 2013-11-25 15:47:54 PST

Comment on attachment 217832 [details]
Remove private _data ivars from interfaces

Clearing flags on attachment: 217832

Committed r159770: <http://trac.webkit.org/changeset/159770>

Comment 10 WebKit Commit Bot 2013-11-25 15:47:56 PST

All reviewed patches have been landed.  Closing bug.