Bug 123064 - REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
Summary: REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-19 11:57 PDT by Ryosuke Niwa
Modified: 2013-10-19 14:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch (38.38 KB, patch)
2013-10-19 14:11 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (57.17 KB, patch)
2013-10-19 14:16 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-19 11:57:50 PDT 
http://trac.webkit.org/changeset/155373 regressed port detection mechanism in EWS.

This patch needs to be either rolled out manually or the regression needs to be fixed ASAP.
Comment 1 Ryosuke Niwa 2013-10-19 12:00:41 PDT 
Seriously, EWS needs to be rewritten. The current implementation is too fragile.

And we need to stop doing these refactoring until that's done because we're going to break things one way or another in the current state.
Comment 2 Zan Dobersek 2013-10-19 14:11:27 PDT 
Created attachment 214668 [details]
Patch
Comment 3 WebKit Commit Bot 2013-10-19 14:13:04 PDT 
Attachment 214668 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/main.py", line 36, in <module>
    from webkitpy.common.config.ports import DeprecatedPort
ImportError: No module named ports


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ryosuke Niwa 2013-10-19 14:15:36 PDT 
Comment on attachment 214668 [details]
Patch

r=me provided the deleted files are being added. Thanks!
Comment 5 Zan Dobersek 2013-10-19 14:16:47 PDT 
Created attachment 214669 [details]
Patch
Comment 6 Zan Dobersek 2013-10-19 14:23:41 PDT 
Comment on attachment 214669 [details]
Patch

Clearing flags on attachment: 214669

Committed r157682: <http://trac.webkit.org/changeset/157682>
Comment 7 Zan Dobersek 2013-10-19 14:23:47 PDT 
All reviewed patches have been landed.  Closing bug.