Bug 123061 - StyleResolver should deal in PassRef<RenderStyle> where possible.
Summary: StyleResolver should deal in PassRef<RenderStyle> where possible.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-19 09:21 PDT by Andreas Kling
Modified: 2013-10-19 09:47 PDT (History)
9 users (show)

See Also:


Attachments
Patch (7.25 KB, patch)
2013-10-19 09:23 PDT, Andreas Kling
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-19 09:21:28 PDT
StyleResolver should deal in PassRef<RenderStyle> where possible.
Comment 1 Andreas Kling 2013-10-19 09:23:49 PDT
Created attachment 214654 [details]
Patch
Comment 2 Anders Carlsson 2013-10-19 09:26:18 PDT
Comment on attachment 214654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214654&action=review

> Source/WebCore/dom/Document.cpp:1855
> +    Ref<RenderStyle> pageStyle(ensureStyleResolver().styleForPage(pageIndex));

I think using pageStyle = is more clear here.
Comment 3 Andreas Kling 2013-10-19 09:47:36 PDT
Committed r157672: <http://trac.webkit.org/changeset/157672>