Bug 123052 – [iOS] Upstream more ARMv7s bits

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Daniel Bates]

Upstream some more bits for ARMv7{f, s}.

[Daniel Bates]

Created attachment 214621 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 214621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214621&action=review

r=me

> Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:44
>  CLANG_ENABLE_OBJC_ARC = $(CLANG_ENABLE_OBJC_ARC_$(CURRENT_ARCH));
> +CLANG_ENABLE_OBJC_ARC_i386 = YES;
>  CLANG_ENABLE_OBJC_ARC_x86_64 = YES;
>  CLANG_ENABLE_OBJC_ARC_arm64 = YES;
>  CLANG_ENABLE_OBJC_ARC_armv7 = YES;

This has armv7s (out of context), should it also have armv7f?

[Daniel Bates]

(In reply to comment #2)
> > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:44
> >  CLANG_ENABLE_OBJC_ARC = $(CLANG_ENABLE_OBJC_ARC_$(CURRENT_ARCH));
> > +CLANG_ENABLE_OBJC_ARC_i386 = YES;
> >  CLANG_ENABLE_OBJC_ARC_x86_64 = YES;
> >  CLANG_ENABLE_OBJC_ARC_arm64 = YES;
> >  CLANG_ENABLE_OBJC_ARC_armv7 = YES;
> 
> This has armv7s (out of context), should it also have armv7f?

After talking with David Kilzer today (10/22) on IRC we can omit support for armv7f from this patch. I'll land only the armv7s parts of this patch.

[Daniel Bates]

(In reply to comment #3)
> [...] I'll land only the armv7s parts of this patch.

I'll also land the CLANG_ENABLE_OBJC_ARC_i386 change.

[Daniel Bates]

Committed r157819: <http://trac.webkit.org/changeset/157819>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 123180

[Daniel Bates]

Committed r157862: <http://trac.webkit.org/changeset/157862>