Bug 123045 - [iOS] Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout()
Summary: [iOS] Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-18 16:16 PDT by Daniel Bates
Modified: 2013-10-21 16:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.02 KB, patch)
2013-10-18 16:19 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (10.71 KB, patch)
2013-10-18 17:10 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (13.45 KB, patch)
2013-10-21 08:33 PDT, Daniel Bates 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-10-18 16:16:00 PDT 
Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout() and JSDOMWindowBase::shouldInterruptScriptBeforeTimeout().
Comment 1 Daniel Bates 2013-10-18 16:19:54 PDT 
Created attachment 214612 [details]
Patch

I plan to post the iOS chrome client implementation in a subsequent patch.
Comment 2 EFL EWS Bot 2013-10-18 16:40:55 PDT 
Comment on attachment 214612 [details]
Patch

Attachment 214612 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6408029
Comment 3 Build Bot 2013-10-18 16:48:31 PDT 
Comment on attachment 214612 [details]
Patch

Attachment 214612 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6458021
Comment 4 Daniel Bates 2013-10-18 17:10:41 PDT 
Created attachment 214620 [details]
Patch
Comment 5 Build Bot 2013-10-18 17:50:43 PDT 
Comment on attachment 214620 [details]
Patch

Attachment 214620 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4918029
Comment 6 EFL EWS Bot 2013-10-18 18:06:34 PDT 
Comment on attachment 214620 [details]
Patch

Attachment 214620 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5848035
Comment 7 Build Bot 2013-10-18 18:18:17 PDT 
Comment on attachment 214620 [details]
Patch

Attachment 214620 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5778027
Comment 8 Build Bot 2013-10-18 19:16:20 PDT 
Comment on attachment 214620 [details]
Patch

Attachment 214620 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5858056
Comment 9 EFL EWS Bot 2013-10-20 11:14:59 PDT 
Comment on attachment 214620 [details]
Patch

Attachment 214620 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/7828005
Comment 10 Daniel Bates 2013-10-21 08:33:02 PDT 
Created attachment 214742 [details]
Patch
Comment 11 Joseph Pecoraro 2013-10-21 16:45:38 PDT 
Comment on attachment 214742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214742&action=review

r=me

> Source/WebCore/loader/EmptyClients.h:195
> +    virtual bool isStopping() OVERRIDE { return false };

Would this build? I think the semicolon at the end of the line should be after "return false".
Comment 12 Daniel Bates 2013-10-21 16:50:12 PDT 
(In reply to comment #11)
> > Source/WebCore/loader/EmptyClients.h:195
> > +    virtual bool isStopping() OVERRIDE { return false };
> 
> Would this build? I think the semicolon at the end of the line should be after "return false".

Will fix before landing.
Comment 13 Daniel Bates 2013-10-21 16:52:53 PDT 
Committed r157764: <http://trac.webkit.org/changeset/157764>