Bug 123037 – Remove excess reserved space in ctiTrampoline frames for X86 and X86_64

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming soon.

[Mark Lam]

Created attachment 214606 [details]
the patch.

[WebKit Commit Bot]

Attachment 214606 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JITStubsX86.h', u'Source/JavaScriptCore/jit/JITStubsX86_64.h']" exit_code: 1
Source/JavaScriptCore/jit/JITStubsX86.h:59:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITStubsX86.h:260:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 214606 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=214606&action=review

>> Source/JavaScriptCore/jit/JITStubsX86.h:59
>> +    // JIT Operation can use up to 6 arguments right now.  So, we need to
> 
> Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]

Will fix before landing.

>> Source/JavaScriptCore/jit/JITStubsX86.h:260
>> +            call [esp + 0x30];
> 
> Extra space before [  [whitespace/braces] [5]

This is not a valid issue.

[Geoffrey Garen]

Comment on attachment 214606 [details]
the patch.

r=me

[Mark Lam]

Thanks for the review.  Landed in r157650: <http://trac.webkit.org/r157650>.