Bug 123037 - Remove excess reserved space in ctiTrampoline frames for X86 and X86_64
Summary: Remove excess reserved space in ctiTrampoline frames for X86 and X86_64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 116888
  Show dependency treegraph
 
Reported: 2013-10-18 14:16 PDT by Mark Lam
Modified: 2013-10-18 15:56 PDT (History)
6 users (show)

See Also:


Attachments
the patch. (4.79 KB, patch)
2013-10-18 15:08 PDT, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-10-18 14:16:38 PDT
Patch coming soon.
Comment 1 Mark Lam 2013-10-18 15:08:45 PDT
Created attachment 214606 [details]
the patch.
Comment 2 WebKit Commit Bot 2013-10-18 15:09:25 PDT
Attachment 214606 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JITStubsX86.h', u'Source/JavaScriptCore/jit/JITStubsX86_64.h']" exit_code: 1
Source/JavaScriptCore/jit/JITStubsX86.h:59:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITStubsX86.h:260:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2013-10-18 15:11:41 PDT
Comment on attachment 214606 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=214606&action=review

>> Source/JavaScriptCore/jit/JITStubsX86.h:59
>> +    // JIT Operation can use up to 6 arguments right now.  So, we need to
> 
> Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]

Will fix before landing.

>> Source/JavaScriptCore/jit/JITStubsX86.h:260
>> +            call [esp + 0x30];
> 
> Extra space before [  [whitespace/braces] [5]

This is not a valid issue.
Comment 4 Geoffrey Garen 2013-10-18 15:25:18 PDT
Comment on attachment 214606 [details]
the patch.

r=me
Comment 5 Mark Lam 2013-10-18 15:56:26 PDT
Thanks for the review.  Landed in r157650: <http://trac.webkit.org/r157650>.