Bug 123035 - Unable to upload <img src="foo.svg"> as WebGL texture
Summary: Unable to upload <img src="foo.svg"> as WebGL texture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-18 13:18 PDT by Dean Jackson
Modified: 2015-01-04 05:00 PST (History)
8 users (show)

See Also:

Attachments
Patch (14.95 KB, patch)
2013-10-18 13:29 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-10-18 13:18:53 PDT 
You can't use texture2D with an HTMLImageElement if that image is pointing to an SVG resource.

<rdar://problem/15247691>
Comment 1 Dean Jackson 2013-10-18 13:29:03 PDT 
Created attachment 214599 [details]
Patch
Comment 2 Tim Horton 2013-10-18 13:41:32 PDT 
Comment on attachment 214599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214599&action=review

> Source/WebCore/ChangeLog:10
> +        Note that the SVG image still needs to have an intrinsic

s/intrinsic/explicit/?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3829
> +    IntRect destRect(0, 0, size.width(), size.height());

destRect(IntPoint(), size)?
Comment 3 Dean Jackson 2013-10-18 13:55:33 PDT 
Committed r157647: <http://trac.webkit.org/changeset/157647>
Comment 4 Dean Jackson 2013-10-18 13:58:04 PDT 
CC Ken in case Chrome doesn't already do this.
Comment 5 Philip Rogers 2013-10-18 14:37:08 PDT 
(In reply to comment #4)
> CC Ken in case Chrome doesn't already do this.

On it :)
http://crbug.com/309161