Bug 123025 – MediaStreamTrack now tracks its own state

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

The spec says that a MediaStreamSource can be shared by different tracks, so a track must have its own state tracking.
In the old implementation if a user invoked the stop method, its readyState method was still returning the MediaStreamSource state, which was wrong.
This also adds a setEnabled method, which can be used to set the state of a track when a remote peer ends it, for instance.

[Thiago de Barros Lacerda]

Created attachment 214581 [details]
Patch

[Jer Noble]

Comment on attachment 214581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214581&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:80
> +    m_state = m_source ? (TrackState) m_source->readyState() : MediaStreamTrack::New;

The space between the cast and variable is unnecessary, but I'm more worried about the cast itself.  There should only be one instance of this enum, either in MediaStreamTrack, or MediaStreamSource.

So, if you reverted the m_readyState -> m_state change, removed the MediaStreamTrack::TrackState enum, and kept the new setState() method (but renamed it setReadyState()), this patch would be a lot simpler.

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:307
> +    setState((TrackState) m_source->readyState());

Ditto.

[Thiago de Barros Lacerda]

(In reply to comment #2)
> (From update of attachment 214581 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214581&action=review
> 
> > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:80
> > +    m_state = m_source ? (TrackState) m_source->readyState() : MediaStreamTrack::New;
> 
> The space between the cast and variable is unnecessary, but I'm more worried about the cast itself.  There should only be one instance of this enum, either in MediaStreamTrack, or MediaStreamSource.
> 
> So, if you reverted the m_readyState -> m_state change, removed the MediaStreamTrack::TrackState enum, and kept the new setState() method (but renamed it setReadyState()), this patch would be a lot simpler.
> 
> > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:307
> > +    setState((TrackState) m_source->readyState());
> 
> Ditto.

Sounds good.

[Thiago de Barros Lacerda]

Created attachment 214772 [details]
Patch

[Jer Noble]

Comment on attachment 214772 [details]
Patch

Looks good. r=me.

[WebKit Commit Bot]

Comment on attachment 214772 [details]
Patch

Clearing flags on attachment: 214772

Committed r157733: <http://trac.webkit.org/changeset/157733>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.