Bug 123024 - Group 64-bit specific and 32-bit specific callOperation implementations in JITInlines.h
Summary: Group 64-bit specific and 32-bit specific callOperation implementations in JI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-18 08:18 PDT by Julien Brianceau
Modified: 2013-10-18 10:02 PDT (History)
2 users (show)

See Also:


Attachments
Put 64-bit callOperation implementations under USE(JSVALUE64) condition. (4.31 KB, patch)
2013-10-18 08:39 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff
Group 64-bit specific and 32-bit specific callOperation implementations (16.61 KB, patch)
2013-10-18 09:10 PDT, Julien Brianceau
msaboff: review+
jbriance: commit-queue-
Details | Formatted Diff | Diff
Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased) (16.14 KB, patch)
2013-10-18 09:38 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-10-18 08:18:19 PDT
The following functions in jit/JITInlines.h should be under #if USE(JSVALUE64) condition:

    ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(J_JITOperation_EJJ operation, int dst, GPRReg arg1, GPRReg arg2)
    {
        setupArgumentsWithExecState(arg1, arg2);
        return appendCallWithExceptionCheckSetJSValueResult(operation, dst);
    }

    ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(S_JITOperation_EJJ operation, RegisterID regOp1, RegisterID regOp2)
    {
        setupArgumentsWithExecState(regOp1, regOp2);
        return appendCallWithExceptionCheck(operation);
    }


This is not a big deal, but could be a bit confusing when reading the code.
Comment 1 Julien Brianceau 2013-10-18 08:39:38 PDT
Created attachment 214576 [details]
Put 64-bit callOperation implementations under USE(JSVALUE64) condition.

There are few other functions involved actually.
Comment 2 Michael Saboff 2013-10-18 08:50:54 PDT
Comment on attachment 214576 [details]
Put 64-bit callOperation implementations under USE(JSVALUE64) condition.

r+  Please group these together similar to what's in DFGSpeculativeJIT.h.
Comment 3 Julien Brianceau 2013-10-18 08:51:26 PDT
Comment on attachment 214576 [details]
Put 64-bit callOperation implementations under USE(JSVALUE64) condition.

Needs grouping
Comment 4 Julien Brianceau 2013-10-18 09:10:22 PDT
Created attachment 214578 [details]
Group 64-bit specific and 32-bit specific callOperation implementations
Comment 5 Julien Brianceau 2013-10-18 09:38:35 PDT
Created attachment 214582 [details]
Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased)

Rebase on top of r157636
Comment 6 Julien Brianceau 2013-10-18 09:44:04 PDT
Comment on attachment 214578 [details]
Group 64-bit specific and 32-bit specific callOperation implementations

Patch will fail to r157636
Comment 7 WebKit Commit Bot 2013-10-18 10:02:14 PDT
Comment on attachment 214582 [details]
Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased)

Clearing flags on attachment: 214582

Committed r157639: <http://trac.webkit.org/changeset/157639>
Comment 8 WebKit Commit Bot 2013-10-18 10:02:16 PDT
All reviewed patches have been landed.  Closing bug.