Bug 123004 - Antialias underlines if they're not axis-aligned
Summary: Antialias underlines if they're not axis-aligned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-17 17:25 PDT by Myles C. Maxfield
Modified: 2013-10-23 13:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (310.33 KB, patch)
2013-10-22 16:48 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (310.45 KB, patch)
2013-10-23 11:55 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (311.48 KB, patch)
2013-10-23 12:11 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2013-10-17 17:25:44 PDT 
Antialias underlines if they're not axis-aligned
Comment 1 Myles C. Maxfield 2013-10-22 16:48:42 PDT 
Created attachment 214905 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-10-23 10:42:57 PDT 
<rdar://problem/15299802>
Comment 3 Simon Fraser (smfr) 2013-10-23 11:28:37 PDT 
Comment on attachment 214905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214905&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1256
> +    if (!printing && getCTM(GraphicsContext::DefinitelyIncludeDeviceScale).preservesAxisAlignment()) {

This is going to be a light perf hit, but not sure if it is measurable.
Comment 4 WebKit Commit Bot 2013-10-23 11:29:45 PDT 
Comment on attachment 214905 [details]
Patch

Rejecting attachment 214905 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 214905, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6078091
Comment 5 Myles C. Maxfield 2013-10-23 11:55:23 PDT 
Created attachment 214978 [details]
Patch
Comment 6 Simon Fraser (smfr) 2013-10-23 11:57:20 PDT 
Comment on attachment 214978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214978&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Tests: svg/custom/foreign-object-skew.html

You need to explain the change.
Comment 7 Myles C. Maxfield 2013-10-23 12:11:35 PDT 
Created attachment 214979 [details]
Patch
Comment 8 WebKit Commit Bot 2013-10-23 13:13:00 PDT 
Comment on attachment 214979 [details]
Patch

Clearing flags on attachment: 214979

Committed r157878: <http://trac.webkit.org/changeset/157878>
Comment 9 WebKit Commit Bot 2013-10-23 13:13:02 PDT 
All reviewed patches have been landed.  Closing bug.