RESOLVED FIXED 123004
Antialias underlines if they're not axis-aligned 
https://bugs.webkit.org/show_bug.cgi?id=123004
Summary Antialias underlines if they're not axis-aligned
Myles C. Maxfield
Reported 2013-10-17 17:25:44 PDT
Antialias underlines if they're not axis-aligned
Attachments
Patch (310.33 KB, patch)
2013-10-22 16:48 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (310.45 KB, patch)
2013-10-23 11:55 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (311.48 KB, patch)
2013-10-23 12:11 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2013-10-22 16:48:42 PDT
Created attachment 214905 [details] Patch
Radar WebKit Bug Importer
Comment 2 2013-10-23 10:42:57 PDT
<rdar://problem/15299802>
Simon Fraser (smfr)
Comment 3 2013-10-23 11:28:37 PDT
Comment on attachment 214905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214905&action=review > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1256 > + if (!printing && getCTM(GraphicsContext::DefinitelyIncludeDeviceScale).preservesAxisAlignment()) { This is going to be a light perf hit, but not sure if it is measurable.
WebKit Commit Bot
Comment 4 2013-10-23 11:29:45 PDT
Comment on attachment 214905 [details] Patch Rejecting attachment 214905 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 214905, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6078091
Myles C. Maxfield
Comment 5 2013-10-23 11:55:23 PDT
Created attachment 214978 [details] Patch
Simon Fraser (smfr)
Comment 6 2013-10-23 11:57:20 PDT
Comment on attachment 214978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214978&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + Tests: svg/custom/foreign-object-skew.html You need to explain the change.
Myles C. Maxfield
Comment 7 2013-10-23 12:11:35 PDT
Created attachment 214979 [details] Patch
WebKit Commit Bot
Comment 8 2013-10-23 13:13:00 PDT
Comment on attachment 214979 [details] Patch Clearing flags on attachment: 214979 Committed r157878: <http://trac.webkit.org/changeset/157878>
WebKit Commit Bot
Comment 9 2013-10-23 13:13:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.