Bug 122987 – Fix three bugs in the equals() implementations for css gradients.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

Fix three bugs in the equals() implementations for css gradients.

[Nico Weber]

Created attachment 214492 [details]
Patch

[Andreas Kling]

Comment on attachment 214492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214492&action=review

r=me, but..

> Source/WebCore/css/CSSGradientValue.cpp:737
>      else
> -        equalXorY = !other.m_firstX || !other.m_firstY;
> +        equalXandY = !other.m_firstX && !other.m_firstY;

Don't we already know that both firstX and firstY are null at this point?

> Source/WebCore/css/CSSGradientValue.cpp:1149
>      else
> -        equalXorY == !other.m_firstX || !other.m_firstY;
> +        equalXandY = !other.m_firstX && !other.m_firstY;

And here?

[Nico Weber]

Comment on attachment 214492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214492&action=review

Thanks!

>> Source/WebCore/css/CSSGradientValue.cpp:737
>> +        equalXandY = !other.m_firstX && !other.m_firstY;
> 
> Don't we already know that both firstX and firstY are null at this point?

Yes, but only for this, not for other

[Andreas Kling]

(In reply to comment #3)
> (From update of attachment 214492 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214492&action=review
> 
> Thanks!
> 
> >> Source/WebCore/css/CSSGradientValue.cpp:737
> >> +        equalXandY = !other.m_firstX && !other.m_firstY;
> > 
> > Don't we already know that both firstX and firstY are null at this point?
> 
> Yes, but only for this, not for other

Durr. :|

[WebKit Commit Bot]

Comment on attachment 214492 [details]
Patch

Clearing flags on attachment: 214492

Committed r157598: <http://trac.webkit.org/changeset/157598>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.