Bug 122972 - Don't add an include for return type of a [Custom] function in generated bindings code
Summary: Don't add an include for return type of a [Custom] function in generated bind...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 122679
  Show dependency tree / graph
 
Reported: 2013-10-17 10:30 PDT by Alexey Proskuryakov
Modified: 2013-10-17 17:51 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (1.72 KB, patch)
2013-10-17 10:32 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-17 10:30:32 PDT 
Custom functions are not implemented in generated files, so there is no reason to include headers for their types. We already have this behavior for their argument types.

This is a minor roadblock for WebCrypto, where I have custom functions that return promises, but no matching headers for promise types. And a desirable behavior in any case, I think.
Comment 1 Alexey Proskuryakov 2013-10-17 10:32:05 PDT 
Created attachment 214470 [details]
proposed patch
Comment 2 WebKit Commit Bot 2013-10-17 17:51:17 PDT 
Comment on attachment 214470 [details]
proposed patch

Clearing flags on attachment: 214470

Committed r157615: <http://trac.webkit.org/changeset/157615>
Comment 3 WebKit Commit Bot 2013-10-17 17:51:20 PDT 
All reviewed patches have been landed.  Closing bug.