Bug 122958 - [WK2] REGRESSION(r156472): scrolling coordinator is always enabled incorrectly.
Summary: [WK2] REGRESSION(r156472): scrolling coordinator is always enabled incorrectly.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-17 05:27 PDT by Attila Dusnoki
Modified: 2013-10-17 10:58 PDT (History)
7 users (show)

See Also:

Attachments
Proposed patch (1.38 KB, patch)
2013-10-17 05:40 PDT, Attila Dusnoki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Dusnoki 2013-10-17 05:27:36 PDT 
http://trac.webkit.org/changeset/156472/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

324	    m_useThreadedScrolling = parameters.store.getBoolValueForKey(WebPreferencesKey::threadedScrollingEnabledKey()); 
325	    m_page->settings().setScrollingCoordinatorEnabled(m_useThreadedScrolling);

You can easily reproduce it on WebKitNix's MiniBrowser in desktop mode where scrolling doesn't work at all.
I think the lines above should be in #if ENABLE(THREADED_SCROLLING) guard.

USE(COORDINATED_GRAPHICS) platforms set ScrollingCoordinatorEnabled in WebPage::setUseFixedLayout(bool fixed) depends on mobile or desktop mode.
Comment 1 Attila Dusnoki 2013-10-17 05:40:58 PDT 
Created attachment 214446 [details]
Proposed patch
Comment 2 Tim Horton 2013-10-17 10:32:14 PDT 
Whoops. This might explain what happened on Lion a few days ago :|
Comment 3 WebKit Commit Bot 2013-10-17 10:58:31 PDT 
Comment on attachment 214446 [details]
Proposed patch

Clearing flags on attachment: 214446

Committed r157580: <http://trac.webkit.org/changeset/157580>
Comment 4 WebKit Commit Bot 2013-10-17 10:58:34 PDT 
All reviewed patches have been landed.  Closing bug.