Bug 122953 - DataRef<T> should use Ref<T> internally.
Summary: DataRef<T> should use Ref<T> internally.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-17 03:51 PDT by Andreas Kling
Modified: 2013-10-17 05:14 PDT (History)
10 users (show)

See Also:


Attachments
Patch (30.18 KB, patch)
2013-10-17 04:06 PDT, Andreas Kling
koivisto: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (30.87 KB, patch)
2013-10-17 04:52 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-17 03:51:49 PDT
DataRef never wraps a null pointer, so it should use Ref internally to avoid unnecessary null checks.
Comment 1 Andreas Kling 2013-10-17 04:06:22 PDT
Created attachment 214439 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-17 04:15:07 PDT
Comment on attachment 214439 [details]
Patch

Attachment 214439 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/4110430
Comment 3 kov's GTK+ EWS bot 2013-10-17 04:21:27 PDT
Comment on attachment 214439 [details]
Patch

Attachment 214439 [details] did not pass gtk-wk2-ews (gtk-wk2):
Output: http://webkit-queues.appspot.com/results/4105473
Comment 4 Build Bot 2013-10-17 04:49:14 PDT
Comment on attachment 214439 [details]
Patch

Attachment 214439 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3476033
Comment 5 Andreas Kling 2013-10-17 04:52:10 PDT
Created attachment 214440 [details]
Patch for landing
Comment 6 Andreas Kling 2013-10-17 05:14:15 PDT
Committed r157568: <http://trac.webkit.org/changeset/157568>