Bug 122940 – A CodeBlock's StructureStubInfos shouldn't be in a Vector that we search using code origins and machine code PCs

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 214520 [details]
work in progress

[Filip Pizlo]

Created attachment 214540 [details]
getting close

Still have a bunch of gluing to do...

[Filip Pizlo]

Created attachment 214541 [details]
sort of starting to compile

[Filip Pizlo]

Created attachment 214543 [details]
it compiles!

And of course it doesn't work at all, yet.

[Oliver Hunt]

(In reply to comment #4)
> Created an attachment (id=214543) [details]
> it compiles!
> 
> And of course it doesn't work at all, yet.

Details, details.

RS=me

:D

[Oliver Hunt]

Comment on attachment 214543 [details]
it compiles!

View in context: https://bugs.webkit.org/attachment.cgi?id=214543&action=review

> Source/WTF/wtf/BagToHashMap.h:35
> +void toHashMap(Bag<ElementType>& bag, KeyGetterFunctor& getKey, HashMap<KeyType, ElementType*>& result)

const Bag&?

[Filip Pizlo]

(In reply to comment #6)
> (From update of attachment 214543 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214543&action=review
> 
> > Source/WTF/wtf/BagToHashMap.h:35
> > +void toHashMap(Bag<ElementType>& bag, KeyGetterFunctor& getKey, HashMap<KeyType, ElementType*>& result)
> 
> const Bag&?

Then I'd have to add const versions of Bag's iterator.

If we ever find this to be a worthwhile thing to do then we can do it.

[Filip Pizlo]

Created attachment 214627 [details]
the patch

[WebKit Commit Bot]

Attachment 214627 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/CodeBlock.h', u'Source/JavaScriptCore/bytecode/CodeOrigin.h', u'Source/JavaScriptCore/bytecode/GetByIdStatus.cpp', u'Source/JavaScriptCore/bytecode/GetByIdStatus.h', u'Source/JavaScriptCore/bytecode/PutByIdStatus.cpp', u'Source/JavaScriptCore/bytecode/PutByIdStatus.h', u'Source/JavaScriptCore/bytecode/StructureStubInfo.h', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGJITCompiler.cpp', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/CCallHelpers.h', u'Source/JavaScriptCore/jit/JIT.cpp', u'Source/JavaScriptCore/jit/JIT.h', u'Source/JavaScriptCore/jit/JITInlines.h', u'Source/JavaScriptCore/jit/JITOperations.cpp', u'Source/JavaScriptCore/jit/JITOperations.h', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/jit/Repatch.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmakefile.list.am', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/BagToHashMap.h', u'Source/WTF/wtf/CMakeLists.txt']" exit_code: 1
Source/JavaScriptCore/bytecode/GetByIdStatus.h:74:  The parameter name "map" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/bytecode/CodeBlock.h:929:  The parameter name "map" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Created attachment 214628 [details]
the patch

[Filip Pizlo]

Created attachment 214629 [details]
the patch

[Oliver Hunt]

Comment on attachment 214629 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214629&action=review

> Source/WTF/wtf/CMakeLists.txt:7
> +    BatToHashMap.h

Halloween already?

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/157660