Add a new flakiness dashboard clone
Created attachment 214416 [details] Adds the app
Created attachment 214418 [details] Removed defer attributes
My plan is to check this initial version in and then iterate over time instead of trying to address all use cases, etc... We can always delete it if we later find that the existing flamines dashboard is better.
Comment on attachment 214418 [details] Removed defer attributes View in context: https://bugs.webkit.org/attachment.cgi?id=214418&action=review > Websites/test-results/index.html:23 > + var urls = removeJunkFromResultsPage(removeJunksFromNRWTStdout(rawInput)).split('\n'); Junks should probably be Junk here.
Committed r157555: <http://trac.webkit.org/changeset/157555>
Is this already deployed on one of webkit.org servers? I have some security concerns that may limit where this can be deployed.
(In reply to comment #6) > Is this already deployed on one of webkit.org servers? I have some security concerns that may limit where this can be deployed. No. What are your security concerns?
Flakiness dashboard is particularly vulnerable because it's a persistent database that any attacker can write arbitrary data to. While there is some validation in report.php, I think that it's best to have multiple layers or protection, ideally by isolating it to its own domain.
(In reply to comment #8) > Flakiness dashboard is particularly vulnerable because it's a persistent database that any attacker can write arbitrary data to. With that token, the current flakiness dashboard also can also store arbitrary data any attacker sends. > While there is some validation in report.php, I think that it's best to have multiple layers or protection, ideally by isolating it to its own domain. Indeed. We'll probably host it at test-results.webkit.org.