Bug 122935 - Support multiple repositories in submitting results to --results-server-host
Summary: Support multiple repositories in submitting results to --results-server-host
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 19:24 PDT by Ryosuke Niwa
Modified: 2013-10-16 19:40 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (5.07 KB, patch)
2013-10-16 19:24 PDT, Ryosuke Niwa 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-16 19:24:17 PDT 
Support multiple repositories in submitting results to --results-server-host
Comment 1 Ryosuke Niwa 2013-10-16 19:24:52 PDT 
Created attachment 214415 [details]
Fixes the bug
Comment 2 Alexey Proskuryakov 2013-10-16 19:30:18 PDT 
Comment on attachment 214415 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402
> +            ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name),  # FIXME: Pass in build.webkit.org.

webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard?
Comment 3 Ryosuke Niwa 2013-10-16 19:31:47 PDT 
(In reply to comment #2)
> (From update of attachment 214415 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402
> > +            ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name),  # FIXME: Pass in build.webkit.org.
> 
> webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard?

This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating.
Comment 4 Ryosuke Niwa 2013-10-16 19:35:08 PDT 
Committed r157553: <http://trac.webkit.org/changeset/157553>
Comment 5 Alexey Proskuryakov 2013-10-16 19:36:29 PDT 
Comment on attachment 214415 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review

>>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402
>>> +            ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name),  # FIXME: Pass in build.webkit.org.
>> 
>> webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard?
> 
> This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating.

It's super confusing that code in layout_tests/controllers/manager.py is not universal.
Comment 6 Ryosuke Niwa 2013-10-16 19:40:59 PDT 
(In reply to comment #5)
> (From update of attachment 214415 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review
> 
> >>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402
> >>> +            ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name),  # FIXME: Pass in build.webkit.org.
> >> 
> >> webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard?
> > 
> > This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating.
> 
> It's super confusing that code in layout_tests/controllers/manager.py is not universal.

Well, the idea is to get rid of the old code because it's a bloated mess.