WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122933
Remote Layer Tree: Complete support for simple layer properties
https://bugs.webkit.org/show_bug.cgi?id=122933
Summary
Remote Layer Tree: Complete support for simple layer properties
Tim Horton
Reported
2013-10-16 18:20:58 PDT
A few more properties: maskLayer, contentsRect, contentsScale, minificationFilter, magnificationFilter, speed, and timeOffset. And, associated cleanup. This completes the set of straightforward PlatformCALayerRemote properties (ignoring contents, filters, animations, and hierarchy).
Attachments
patch
(25.15 KB, patch)
2013-10-16 18:29 PDT
,
Tim Horton
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2013-10-16 18:29:58 PDT
Created
attachment 214412
[details]
patch
Anders Carlsson
Comment 2
2013-10-16 18:36:26 PDT
Comment on
attachment 214412
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=214412&action=review
> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:121 > + ASSERT(layer->isRemote()); > + if (!layer->isRemote()) > + return;
No need for both an ASSERT and an early return since this only runs with assertions enabled.
Tim Horton
Comment 3
2013-10-16 18:45:09 PDT
http://trac.webkit.org/changeset/157547
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug