Bug 122933 - Remote Layer Tree: Complete support for simple layer properties
Summary: Remote Layer Tree: Complete support for simple layer properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 18:20 PDT by Tim Horton
Modified: 2013-10-16 18:45 PDT (History)
2 users (show)

See Also:

Attachments
patch (25.15 KB, patch)
2013-10-16 18:29 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-16 18:20:58 PDT 
A few more properties: maskLayer, contentsRect, contentsScale, minificationFilter, magnificationFilter, speed, and timeOffset. And, associated cleanup.

This completes the set of straightforward PlatformCALayerRemote properties (ignoring contents, filters, animations, and hierarchy).
Comment 1 Tim Horton 2013-10-16 18:29:58 PDT 
Created attachment 214412 [details]
patch
Comment 2 Anders Carlsson 2013-10-16 18:36:26 PDT 
Comment on attachment 214412 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214412&action=review

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:121
> +        ASSERT(layer->isRemote());
> +        if (!layer->isRemote())
> +            return;

No need for both an ASSERT and an early return since this only runs with assertions enabled.
Comment 3 Tim Horton 2013-10-16 18:45:09 PDT 
http://trac.webkit.org/changeset/157547