Bug 122931 - Transition cti_op_throw and cti_vm_throw to a JIT operation
Summary: Transition cti_op_throw and cti_vm_throw to a JIT operation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 122758
  Show dependency treegraph
 
Reported: 2013-10-16 17:38 PDT by Michael Saboff
Modified: 2013-10-17 11:11 PDT (History)
0 users

See Also:


Attachments
Patch (14.33 KB, patch)
2013-10-17 00:18 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff
Updated patch (30.97 KB, patch)
2013-10-17 10:23 PDT, Michael Saboff
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-10-16 17:38:21 PDT
Change cti_op_throw to be a JIT operation.
Comment 1 Michael Saboff 2013-10-17 00:18:02 PDT
Created attachment 214424 [details]
Patch
Comment 2 Filip Pizlo 2013-10-17 07:26:35 PDT
Comment on attachment 214424 [details]
Patch

Why doesn't this just have the code for op_throw call operationDoThrow directly and then perform the jump from JIT code?  Seems like that would be an easier design.
Comment 3 Michael Saboff 2013-10-17 10:23:11 PDT
Created attachment 214468 [details]
Updated patch

(In reply to comment #2)
> (From update of attachment 214424 [details])
> Why doesn't this just have the code for op_throw call operationDoThrow directly and then perform the jump from JIT code?  Seems like that would be an easier design.

Made this suggested change.

Also, since all cti_stubs that had exception checks before returning have been eliminated, I removed cti_vm_throw and it's caller ctiVMThrowTrampoline().
Comment 4 Michael Saboff 2013-10-17 11:11:10 PDT
Committed r157581: <http://trac.webkit.org/changeset/157581>