WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122928
Remove unnecessary check for RenderLayer and rename ensureLayer to createLayer in RenderLayerModelObject.
https://bugs.webkit.org/show_bug.cgi?id=122928
Summary
Remove unnecessary check for RenderLayer and rename ensureLayer to createLaye...
Vivek Galatage
Reported
2013-10-16 16:58:41 PDT
RenderLayerModelObject::styleDidChange() invokes the ensureLayer() method only in case of !layer(). Again checking for layer existence would be deemed redundant in ensureLayer. Replacing it with an ASSERT(!m_layer). Blink Review URL:
https://codereview.chromium.org/27246003/
Attachments
Patch
(3.00 KB, patch)
2013-10-16 17:04 PDT
,
Vivek Galatage
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Vivek Galatage
Comment 1
2013-10-16 17:04:48 PDT
Created
attachment 214406
[details]
Patch
WebKit Commit Bot
Comment 2
2013-10-17 12:13:44 PDT
Comment on
attachment 214406
[details]
Patch Clearing flags on attachment: 214406 Committed
r157587
: <
http://trac.webkit.org/changeset/157587
>
WebKit Commit Bot
Comment 3
2013-10-17 12:13:47 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug