Bug 122928 - Remove unnecessary check for RenderLayer and rename ensureLayer to createLayer in RenderLayerModelObject.
Summary: Remove unnecessary check for RenderLayer and rename ensureLayer to createLaye...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-10-16 16:58 PDT by Vivek Galatage
Modified: 2013-10-17 12:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2013-10-16 17:04 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2013-10-16 16:58:41 PDT 
RenderLayerModelObject::styleDidChange() invokes the ensureLayer() method only in case of !layer().
Again checking for layer existence would be deemed redundant in ensureLayer. Replacing it with an
ASSERT(!m_layer).

Blink Review URL: https://codereview.chromium.org/27246003/
Comment 1 Vivek Galatage 2013-10-16 17:04:48 PDT 
Created attachment 214406 [details]
Patch
Comment 2 WebKit Commit Bot 2013-10-17 12:13:44 PDT 
Comment on attachment 214406 [details]
Patch

Clearing flags on attachment: 214406

Committed r157587: <http://trac.webkit.org/changeset/157587>
Comment 3 WebKit Commit Bot 2013-10-17 12:13:47 PDT 
All reviewed patches have been landed.  Closing bug.