Bug 122917 - Architecture specific implementation in DFG could be avoided
Summary: Architecture specific implementation in DFG could be avoided
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 14:25 PDT by Julien Brianceau
Modified: 2013-10-16 15:08 PDT (History)
2 users (show)

See Also:

Attachments
Remove useless architecture specific implementation in DFG. (2.38 KB, patch)
2013-10-16 14:27 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-10-16 14:25:23 PDT 
When using ARM architecture with HARD_FP, we have FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR == ARMRegisters::d0, so we don't need a specific implementation for this case of the 2 following functions, the fallback one is fine.

  JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result)
  JITCompiler::Call appendCallSetResult(const FunctionPtr& function, FPRReg result)
Comment 1 Julien Brianceau 2013-10-16 14:27:23 PDT 
Created attachment 214396 [details]
Remove useless architecture specific implementation in DFG.
Comment 2 WebKit Commit Bot 2013-10-16 15:08:48 PDT 
Comment on attachment 214396 [details]
Remove useless architecture specific implementation in DFG.

Clearing flags on attachment: 214396

Committed r157532: <http://trac.webkit.org/changeset/157532>
Comment 3 WebKit Commit Bot 2013-10-16 15:08:50 PDT 
All reviewed patches have been landed.  Closing bug.