Bug 122906 - RemoteLayerTree: Add support for more layer properties and transform layers
Summary: RemoteLayerTree: Add support for more layer properties and transform layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 10:41 PDT by Tim Horton
Modified: 2013-10-16 12:05 PDT (History)
2 users (show)

See Also:


Attachments
patch (41.12 KB, patch)
2013-10-16 10:42 PDT, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-16 10:41:21 PDT
Add support for name, border width, border color, opacity, transform, sublayer transform, hidden, geometry flipped, double sided, masks to bounds, and opaque layer properties.

Factor layer creation out from layer changes, so that we can create layers of the correct type. Use this mechanism to create CATransformLayers when handed a LayerTypeTransformLayer.
Comment 1 Tim Horton 2013-10-16 10:42:19 PDT
Created attachment 214373 [details]
patch
Comment 2 Anders Carlsson 2013-10-16 11:35:52 PDT
Comment on attachment 214373 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214373&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:283
> +static void dumpProperty(StringBuilder& builder, String name, const TransformationMatrix& transform)

In the future I think we should just make dumpProperty take a TextStream& instead.
Comment 3 Tim Horton 2013-10-16 12:05:37 PDT
http://trac.webkit.org/changeset/157523