Bug 122902 - r157411 fails run-javascriptcore-tests when run with Baseline JIT
Summary: r157411 fails run-javascriptcore-tests when run with Baseline JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 09:16 PDT by Mark Lam
Modified: 2013-10-16 16:55 PDT (History)
5 users (show)

See Also:

Attachments
the patch (1.81 KB, patch)
2013-10-16 16:25 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-10-16 09:16:01 PDT 
http://trac.webkit.org/changeset/157411 introduced a crash in run-javascriptcore-tests when running only the baseline JIT (no LLINT, no DFG).
Comment 1 Mark Lam 2013-10-16 09:16:42 PDT 
It does not crash in r157409.  Only started with r157411.
Comment 2 Mark Lam 2013-10-16 09:18:23 PDT 
FYI, I was doing testing with 32-bit builds.  Haven't checked if the crash manifests on 64-bit builds yet.
Comment 3 Mark Lam 2013-10-16 10:46:11 PDT 
(In reply to comment #2)
> FYI, I was doing testing with 32-bit builds.  Haven't checked if the crash manifests on 64-bit builds yet.

Correction: it's not a crash.  It's a testapi failure, and run-javascriptcore-tests simply did not continue running thereafter.  The issue also manifests on 64-bit builds.

The failures are:

FAIL: PropertyCatchalls.x should be 4 but instead is 5.
FAIL: Test script returned unexpected value:
Comment 4 Filip Pizlo 2013-10-16 13:04:06 PDT 
I'm looking at this.
Comment 5 Filip Pizlo 2013-10-16 16:25:27 PDT 
Created attachment 214402 [details]
the patch
Comment 6 Mark Hahnenberg 2013-10-16 16:27:21 PDT 
Comment on attachment 214402 [details]
the patch

r=me
Comment 7 Filip Pizlo 2013-10-16 16:55:18 PDT 
Landed in http://trac.webkit.org/changeset/157541