Bug 122889 – [EFL] accessibility/plugin.html passes incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Krzysztof Czech]

It seems, that test works incorrectly. It cannot locate resources/test.swf file.

[Radar WebKit Bug Importer]

<rdar://problem/15239938>

[Andrzej Badowski]

Created attachment 214352 [details]
proposed_patch

[Andrzej Badowski]

Created attachment 214353 [details]
proposed patch 2

[Mario Sanchez Prada]

Comment on attachment 214353 [details]
proposed patch 2

I've just quickly checked for uses of test.swf in the Layout tests directory and found that is used in two more places other than accessibility:

$ git grep "resources/test.swf"
accessibility/plugin.html:       <embed src="resources/test.swf" type="application/x-shockwave-flash">
fast/loader/sandboxed-plugin-crash.html:<iframe src="resources/test.swf" sandbox="allow-same-origin allow-forms allow-scripts"></iframe><br>
fast/replaced/border-radius-clip.html:<embed src="resources/test.swf" style="border:3px solid black; background-color: lime; -webkit-border-radius: 32px; margin-bottom:-32px"
fast/replaced/embed-display-none.html:  <embed style="display:none" src="resources/test.swf"

Additionally, I've also found that all the three different instances of test.swf are actually the same file, duplicated in three different locations:

$ md5sum platform/mac/accessibility/resources/test.swf fast/loader/resources/test.swf fast/replaced/resources/test.swf
140bd629879234796a2334c066a3b9e1  platform/mac/accessibility/resources/test.swf
140bd629879234796a2334c066a3b9e1  fast/loader/resources/test.swf
140bd629879234796a2334c066a3b9e1  fast/replaced/resources/test.swf

So, I think that instead of moving it from platform/mac/accessibility/resources into accessibility/resources, it would be better to put it in LayoutTests/resources/ and update the relative paths in those four tests.

[Andrzej Badowski]

(In reply to comment #4)
> (From update of attachment 214353 [details])
> I've just quickly checked for uses of test.swf in the Layout tests directory and found that is used in two more places other than accessibility:
> 
> $ git grep "resources/test.swf"
> accessibility/plugin.html:       <embed src="resources/test.swf" type="application/x-shockwave-flash">
> fast/loader/sandboxed-plugin-crash.html:<iframe src="resources/test.swf" sandbox="allow-same-origin allow-forms allow-scripts"></iframe><br>
> fast/replaced/border-radius-clip.html:<embed src="resources/test.swf" style="border:3px solid black; background-color: lime; -webkit-border-radius: 32px; margin-bottom:-32px"
> fast/replaced/embed-display-none.html:  <embed style="display:none" src="resources/test.swf"
> 
> Additionally, I've also found that all the three different instances of test.swf are actually the same file, duplicated in three different locations:
> 
> $ md5sum platform/mac/accessibility/resources/test.swf fast/loader/resources/test.swf fast/replaced/resources/test.swf
> 140bd629879234796a2334c066a3b9e1  platform/mac/accessibility/resources/test.swf
> 140bd629879234796a2334c066a3b9e1  fast/loader/resources/test.swf
> 140bd629879234796a2334c066a3b9e1  fast/replaced/resources/test.swf
> 
> So, I think that instead of moving it from platform/mac/accessibility/resources into accessibility/resources, it would be better to put it in LayoutTests/resources/ and update the relative paths in those four tests.

OK, I will do it.

[Andrzej Badowski]

Created attachment 214447 [details]
takes into account recent comments from Mario

[WebKit Commit Bot]

Comment on attachment 214447 [details]
takes into account recent comments from Mario

Clearing flags on attachment: 214447

Committed r157780: <http://trac.webkit.org/changeset/157780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.