Bug 122885 - Remove more of the UNINTERRUPTED_SEQUENCE thing
Summary: Remove more of the UNINTERRUPTED_SEQUENCE thing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-16 00:05 PDT by Julien Brianceau
Modified: 2013-10-16 01:39 PDT (History)
3 users (show)

See Also:


Attachments
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2.93 KB, patch)
2013-10-16 00:09 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) (3.59 KB, patch)
2013-10-16 00:56 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-10-16 00:05:00 PDT
The UNINTERRUPTED_SEQUENCE thing was not completely removed by http://trac.webkit.org/changeset/157481: the 2 following function implementation remain in JITInlines.h file, leading to build failure for SH4 architure.

void JIT::beginUninterruptedSequence(int, int); 
void JIT::endUninterruptedSequence(int, int, int);
Comment 1 Julien Brianceau 2013-10-16 00:09:32 PDT
Created attachment 214345 [details]
Remove beginUninterruptedSequence and endUninterruptedSequence functions

Fix the following compilation error:

In file included from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITCall32_64.cpp:35:0:
/local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITInlines.h:121:81: error: no ‘void JSC::JIT::beginUninterruptedSequence(int, int)’ member function declared in class ‘JSC::JIT’
/local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITInlines.h:147:88: error: no ‘void JSC::JIT::endUninterruptedSequence(int, int, int)’ member function declared in class ‘JSC::JIT’
Comment 2 Julien Brianceau 2013-10-16 00:20:58 PDT
Comment on attachment 214345 [details]
Remove beginUninterruptedSequence and endUninterruptedSequence functions

I forgot to remove something else, I'll submit another patch soon
Comment 3 Julien Brianceau 2013-10-16 00:56:39 PDT
Created attachment 214346 [details]
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2)
Comment 4 Andreas Kling 2013-10-16 01:15:14 PDT
Comment on attachment 214346 [details]
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2)

rs=me
Comment 5 WebKit Commit Bot 2013-10-16 01:39:17 PDT
Comment on attachment 214346 [details]
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2)

Clearing flags on attachment: 214346

Committed r157500: <http://trac.webkit.org/changeset/157500>
Comment 6 WebKit Commit Bot 2013-10-16 01:39:18 PDT
All reviewed patches have been landed.  Closing bug.