RESOLVED FIXED 122875
Build fix after r157478 
https://bugs.webkit.org/show_bug.cgi?id=122875
Summary Build fix after r157478
Jinwoo Song
Reported 2013-10-15 18:58:15 PDT
Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp.o [ 86%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp.o In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:33:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/WebCoreArgumentCoders.h:90:19: error: redefinition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:29:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:62:19: error: previous definition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:27:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/WebCoreArgumentCoders.h:90:19: error: redefinition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:25:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:62:19: error: previous definition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp.o] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
Attachments
Patch (2.54 KB, patch)
2013-10-15 19:01 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (2.75 KB, patch)
2013-10-15 20:20 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2013-10-15 19:01:55 PDT
Created attachment 214329 [details] Patch
Gyuyoung Kim
Comment 2 2013-10-15 19:41:11 PDT
Comment on attachment 214329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214329&action=review Noam needs to take a look this. > Source/WebKit2/ChangeLog:3 > + Build fix after r157478 It looks insufficient bug title. > Source/WebKit2/ChangeLog:7 > + Any description ?
Jinwoo Song
Comment 3 2013-10-15 20:20:58 PDT
Created attachment 214336 [details] Patch
Jinwoo Song
Comment 4 2013-10-15 20:21:50 PDT
Comment on attachment 214329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214329&action=review >> Source/WebKit2/ChangeLog:3 >> + Build fix after r157478 > > It looks insufficient bug title. Changed title. >> Source/WebKit2/ChangeLog:7 >> + > > Any description ? done.
Gyuyoung Kim
Comment 5 2013-10-15 20:32:01 PDT
Comment on attachment 214336 [details] Patch LGTM
WebKit Commit Bot
Comment 6 2013-10-15 21:06:33 PDT
Comment on attachment 214336 [details] Patch Clearing flags on attachment: 214336 Committed r157484: <http://trac.webkit.org/changeset/157484>
WebKit Commit Bot
Comment 7 2013-10-15 21:06:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.