Created attachment 214326 [details] testcase On editable contents, If you backspace before a first character of a line, the line is merged to the upper line with merging parents' style to the inline style. If there are conflicting styles in parent's styles, not the inline style of the parent but the embedded style of the parent is applied (as the attached test case).
Created attachment 214327 [details] Patch
Comment on attachment 214327 [details] Patch Attachment 214327 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3494318 New failing tests: editing/deleting/merge-paragraph-from-p-with-style.html editing/deleting/merge-paragraph-with-style-from-rule.html
Created attachment 214330 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 214327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214327&action=review This patch needs a test case demonstrating it fixes a bug; at minimum it shouldn't regress tests. > Source/WebCore/ChangeLog:9 > + Inline styles need to override other author styles, > + so if DoNotOverrideValues mode, inline styles need to be merged before other author styles. Why?
Created attachment 214339 [details] Patch
(In reply to comment #4) > (From update of attachment 214327 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214327&action=review > > This patch needs a test case demonstrating it fixes a bug; at minimum it shouldn't regress tests. > > > Source/WebCore/ChangeLog:9 > > + Inline styles need to override other author styles, > > + so if DoNotOverrideValues mode, inline styles need to be merged before other author styles. > > Why? I added patch with newly added test case. On the attached test case, if you backspace on the start of the 2nd line, the style for class (color:red) is merged, but the inline style (color:blue) is not merged because it's DoNotOverrideValues mode. Then, as a result, only the style that was not applied is merged, and the color is changed! I think merging inline style first can be a solution for that.
Comment on attachment 214339 [details] Patch Attachment 214339 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4110149 New failing tests: editing/deleting/merge-paragraph-from-p-with-style.html editing/deleting/merge-paragraph-with-style-from-rule.html
Created attachment 214342 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 214343 [details] Patch
Created attachment 214347 [details] Patch
New patch looks much better.
Comment on attachment 214347 [details] Patch Clearing flags on attachment: 214347 Committed r157522: <http://trac.webkit.org/changeset/157522>
All reviewed patches have been landed. Closing bug.