WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122866
Fix 3 operand sub operation in C loop LLINT
https://bugs.webkit.org/show_bug.cgi?id=122866
Summary
Fix 3 operand sub operation in C loop LLINT
Mark Lam
Reported
2013-10-15 14:51:22 PDT
In LLINT asm, "sub a, b, c" means "c = a - b" , not "c = b - a". The LLINT C loop assembler was doing this wrong. This bug results in stack overflow checks not being executed after the recent stack direction inversion. Fix coming soon.
Attachments
the patch.
(1.48 KB, patch)
2013-10-15 14:55 PDT
,
Mark Lam
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2013-10-15 14:55:54 PDT
Created
attachment 214304
[details]
the patch.
Geoffrey Garen
Comment 2
2013-10-15 14:57:55 PDT
Comment on
attachment 214304
[details]
the patch. r=me
Mark Lam
Comment 3
2013-10-15 15:04:06 PDT
Thanks for the review. Landed in
r157473
: <
http://trac.webkit.org/r157473
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug