We have lots of contexts. I initially thought that this was about ScriptExecutionContext.
Created attachment 214301 [details] proposed patch Alternatively, we could use an auto variable to hold the context, and make it work with any classes that have a context() method (as long as the context is registered as an opaque root). Not sure if that's desirable - there is no JS concept of "context", so tying it too deeply into generated code may be misleading. We already have bare "GenerateIsReachable" for those who prefer a universal mechanism.
Created attachment 214302 [details] with ChangeLog updated
(In reply to comment #2) > Created an attachment (id=214302) [details] > with ChangeLog updated Hmm, I think something went wrong and the patch was uploaded as plaintext.
Comment on attachment 214302 [details] with ChangeLog updated Attachment 214302 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4109067
Comment on attachment 214302 [details] with ChangeLog updated Attachment 214302 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/4103046
Comment on attachment 214302 [details] with ChangeLog updated r=me
Created attachment 214307 [details] patch for landing Builds were failing because I overlooked one of IDL files that used the old name (it should have been in Xcode project, but wasn't). Fixed that, and added the file to the project.
Comment on attachment 214307 [details] patch for landing Rejecting attachment 214307 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 214307, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Geoff Garen found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4111121
Comment on attachment 214307 [details] patch for landing How about this?
Comment on attachment 214307 [details] patch for landing Rejecting attachment 214307 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 214307, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Geoff Garen found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/3384163
Created attachment 214338 [details] you not trust me?
Comment on attachment 214338 [details] you not trust me? Clearing flags on attachment: 214338 Committed r157486: <http://trac.webkit.org/changeset/157486>
All reviewed patches have been landed. Closing bug.