Add ftlShouldBe() function to test FTL jitted code.
Created attachment 214298 [details] Patch
Comment on attachment 214298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214298&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2911 > + return JITCode::isOptimizingJITFTL(replacement()->jitType()); I would just say replacement()->jitType() == JITCode::FTLJIT; > Source/JavaScriptCore/jit/JITCode.h:149 > - > + > + static bool isOptimizingJITFTL(JITType jitType) > + { > + return jitType == FTLJIT; > + } > + Don't need this. It would only be useful if we planned to add a fifth tier or something. ;-) > LayoutTests/resources/standalone-pre.js:265 > +function ftlCompiled(argument) > +{ > + if (!("f" in argument)) > + throw new Error("ftlCompiled called with invalid argument."); > + return testRunner.compiledByFTL(argument.f); > +} What happens if this runs in run-webkit-tests? Do you have logic to stub out compiledByFTL()? I don't see the logic to wire compiledByFTL into the DumpRenderTree or WebKitTestRunner testRunner's.
Comment on attachment 214298 [details] Patch Attachment 214298 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3482093 New failing tests: js/ftl-not-string.html
Created attachment 214306 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 214298 [details] Patch Attachment 214298 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4104039 New failing tests: js/ftl-not-string.html
Created attachment 214309 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 214298 [details] Patch Attachment 214298 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4108070 New failing tests: js/ftl-not-string.html
Created attachment 214320 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 214298 [details] Patch Assuming that patches for review since 2013 are stale, r-