Bug 122859 – [GTK] No hover-horizontal scrolling available

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Bastian]

I am unable to perform horizontal scrolling by hovering over the horizontal scrollbar and scroll the scrolling wheel on my mouse at the same time. I am using Ephiphany 3.10.0

This behavior is, however, available in every other gtk based application I know of and use, though. For example Evince, Documents, Libreoffice applications, gedit, inkscape and gimp. I propose it is added to webkitgtk too.

[Carlos Garcia Campos]

Is this specific to GTK+? does it work in mac or EFL?

[Carlos Garcia Campos]

It works for non-primary scrollbars, like scrollbars in a text area.

[Zan Dobersek]

(In reply to comment #2)
> It works for non-primary scrollbars, like scrollbars in a text area.

I think the issue is with the main scrollbar, i.e. the scrollbar of the web view embedded inside Epiphany.

[Carlos Garcia Campos]

Created attachment 271339 [details]
Patch

[Michael Catanzaro]

Comment on attachment 271339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271339&action=review

> Source/WebCore/page/EventHandler.cpp:2649
> +    bool handledEvent = platformCompleteWheelEvent(adjustedEvent, scrollableContainer.get(), scrollableArea);

It looks right, though I wonder how much regression potential this has for other ports.

[Michael Catanzaro]

Er, forgot to ask about a layout test for this? Probably I should have withheld my r+ pending a test; I'm sure you can write one with your new mock animator.

[Carlos Garcia Campos]

(In reply to comment #5)
> Comment on attachment 271339 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271339&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:2649
> > +    bool handledEvent = platformCompleteWheelEvent(adjustedEvent, scrollableContainer.get(), scrollableArea);
> 
> It looks right, though I wonder how much regression potential this has for
> other ports.

In all other ports adjustedEvent == event

[Carlos Garcia Campos]

(In reply to comment #6)
> Er, forgot to ask about a layout test for this? Probably I should have
> withheld my r+ pending a test; I'm sure you can write one with your new mock
> animator.

I'll try to find the time, we don't need the scroll animator tests for this, we can just hover the scrollbar, send wheel event, and check how the view scrolled.

[Carlos Garcia Campos]

Created attachment 271432 [details]
Patch for landing including test

[Carlos Garcia Campos]

Committed r196640: <http://trac.webkit.org/changeset/196640>