Bug 122859 - [GTK] No hover-horizontal scrolling available
Summary: [GTK] No hover-horizontal scrolling available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 420+
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-15 13:39 PDT by Bastian
Modified: 2016-02-16 10:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2016-02-15 06:07 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff
Patch for landing including test (5.15 KB, patch)
2016-02-16 09:36 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bastian 2013-10-15 13:39:12 PDT
I am unable to perform horizontal scrolling by hovering over the horizontal scrollbar and scroll the scrolling wheel on my mouse at the same time. I am using Ephiphany 3.10.0

This behavior is, however, available in every other gtk based application I know of and use, though. For example Evince, Documents, Libreoffice applications, gedit, inkscape and gimp. I propose it is added to webkitgtk too.
Comment 1 Carlos Garcia Campos 2013-10-16 00:53:43 PDT
Is this specific to GTK+? does it work in mac or EFL?
Comment 2 Carlos Garcia Campos 2013-10-16 01:14:37 PDT
It works for non-primary scrollbars, like scrollbars in a text area.
Comment 3 Zan Dobersek 2013-10-16 06:21:01 PDT
(In reply to comment #2)
> It works for non-primary scrollbars, like scrollbars in a text area.

I think the issue is with the main scrollbar, i.e. the scrollbar of the web view embedded inside Epiphany.
Comment 4 Carlos Garcia Campos 2016-02-15 06:07:41 PST
Created attachment 271339 [details]
Patch
Comment 5 Michael Catanzaro 2016-02-15 22:05:45 PST
Comment on attachment 271339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271339&action=review

> Source/WebCore/page/EventHandler.cpp:2649
> +    bool handledEvent = platformCompleteWheelEvent(adjustedEvent, scrollableContainer.get(), scrollableArea);

It looks right, though I wonder how much regression potential this has for other ports.
Comment 6 Michael Catanzaro 2016-02-15 22:08:23 PST
Er, forgot to ask about a layout test for this? Probably I should have withheld my r+ pending a test; I'm sure you can write one with your new mock animator.
Comment 7 Carlos Garcia Campos 2016-02-16 00:15:48 PST
(In reply to comment #5)
> Comment on attachment 271339 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271339&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:2649
> > +    bool handledEvent = platformCompleteWheelEvent(adjustedEvent, scrollableContainer.get(), scrollableArea);
> 
> It looks right, though I wonder how much regression potential this has for
> other ports.

In all other ports adjustedEvent == event
Comment 8 Carlos Garcia Campos 2016-02-16 00:16:50 PST
(In reply to comment #6)
> Er, forgot to ask about a layout test for this? Probably I should have
> withheld my r+ pending a test; I'm sure you can write one with your new mock
> animator.

I'll try to find the time, we don't need the scroll animator tests for this, we can just hover the scrollbar, send wheel event, and check how the view scrolled.
Comment 9 Carlos Garcia Campos 2016-02-16 09:36:43 PST
Created attachment 271432 [details]
Patch for landing including test
Comment 10 Carlos Garcia Campos 2016-02-16 10:15:46 PST
Committed r196640: <http://trac.webkit.org/changeset/196640>