Bug 122832 - [GStreamer] use a smart pointer for ::setStreamVolumeElement()
Summary: [GStreamer] use a smart pointer for ::setStreamVolumeElement()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 79203
  Show dependency tree / graph
 
Reported: 2013-10-15 07:43 PDT by Philippe Normand
Modified: 2013-10-17 05:52 PDT (History)
12 users (show)

See Also:

Attachments
patch (1.82 KB, patch)
2013-10-15 08:30 PDT, Philippe Normand 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch (2.61 KB, patch)
2013-10-15 08:40 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2013-10-15 07:43:54 PDT 
SSIA
Comment 1 Philippe Normand 2013-10-15 08:30:06 PDT 
Created attachment 214260 [details]
patch
Comment 2 EFL EWS Bot 2013-10-15 08:33:23 PDT 
Comment on attachment 214260 [details]
patch

Attachment 214260 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/4099038
Comment 3 EFL EWS Bot 2013-10-15 08:34:49 PDT 
Comment on attachment 214260 [details]
patch

Attachment 214260 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/4099039
Comment 4 kov's GTK+ EWS bot 2013-10-15 08:39:43 PDT 
Comment on attachment 214260 [details]
patch

Attachment 214260 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/4099042
Comment 5 Philippe Normand 2013-10-15 08:40:37 PDT 
Created attachment 214264 [details]
patch
Comment 6 Darin Adler 2013-10-15 13:21:38 PDT 
Comment on attachment 214264 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214264&action=review

> Source/WebCore/ChangeLog:10
> +        Use a smart pointer all the way from call site to member variable storage.

Why?
Comment 7 Philippe Normand 2013-10-16 08:09:01 PDT 
(In reply to comment #6)
> (From update of attachment 214264 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214264&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Use a smart pointer all the way from call site to member variable storage.
> 
> Why?

Oh well I thought it'd simply be cleaner but I can't find other reasons and there's no ref leak in the current code.

So I think I'll end up not doing this change.