RESOLVED FIXED 122830
[WinCairo] Build fails. 
https://bugs.webkit.org/show_bug.cgi?id=122830
Summary [WinCairo] Build fails.
peavo
Reported 2013-10-15 07:32:35 PDT
The WinCairo build fails to compile: >..\platform\network\NetworkStorageSessionStub.cpp(49): error C2556: 'WTF::PassOwnPtr WebCore::NetworkStorageSession::createPrivateBrowsingSession(const WTF::String &)' : overloaded function differs only by return type from 'std::unique_ptr<_Ty> WebCore::NetworkStorageSession::createPrivateBrowsingSession(const WTF::String &)' with [ T=WebCore::NetworkStorageSession ] and [ _Ty=WebCore::NetworkStorageSession ] webcore\platform\network\NetworkStorageSession.h(49) : see declaration of 'WebCore::NetworkStorageSession::createPrivateBrowsingSession' 1>..\platform\network\NetworkStorageSessionStub.cpp(49): error C2371: 'WebCore::NetworkStorageSession::createPrivateBrowsingSession' : redefinition; different basic types webcore\platform\network\NetworkStorageSession.h(49) : see declaration of 'WebCore::NetworkStorageSession::createPrivateBrowsingSession
Attachments
Patch (1.28 KB, patch)
2013-10-15 07:36 PDT, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-10-15 07:36:48 PDT
Created attachment 214257 [details] Patch
Brent Fulgham
Comment 2 2013-10-15 09:15:56 PDT
Comment on attachment 214257 [details] Patch r=me
WebKit Commit Bot
Comment 3 2013-10-15 09:38:11 PDT
Comment on attachment 214257 [details] Patch Clearing flags on attachment: 214257 Committed r157450: <http://trac.webkit.org/changeset/157450>
WebKit Commit Bot
Comment 4 2013-10-15 09:38:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.