Bug 122830 - [WinCairo] Build fails.
Summary: [WinCairo] Build fails.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-15 07:32 PDT by peavo
Modified: 2013-10-15 09:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2013-10-15 07:36 PDT, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-10-15 07:32:35 PDT 
The WinCairo build fails to compile:

>..\platform\network\NetworkStorageSessionStub.cpp(49): error C2556: 'WTF::PassOwnPtr WebCore::NetworkStorageSession::createPrivateBrowsingSession(const WTF::String &)' : overloaded function differs only by return type from 'std::unique_ptr<_Ty> WebCore::NetworkStorageSession::createPrivateBrowsingSession(const WTF::String &)' with [ T=WebCore::NetworkStorageSession ] and [ _Ty=WebCore::NetworkStorageSession ] 
webcore\platform\network\NetworkStorageSession.h(49) : see declaration of 'WebCore::NetworkStorageSession::createPrivateBrowsingSession' 
1>..\platform\network\NetworkStorageSessionStub.cpp(49): error C2371: 'WebCore::NetworkStorageSession::createPrivateBrowsingSession' : redefinition; different basic types webcore\platform\network\NetworkStorageSession.h(49) : see declaration of 'WebCore::NetworkStorageSession::createPrivateBrowsingSession
Comment 1 peavo 2013-10-15 07:36:48 PDT 
Created attachment 214257 [details]
Patch
Comment 2 Brent Fulgham 2013-10-15 09:15:56 PDT 
Comment on attachment 214257 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-10-15 09:38:11 PDT 
Comment on attachment 214257 [details]
Patch

Clearing flags on attachment: 214257

Committed r157450: <http://trac.webkit.org/changeset/157450>
Comment 4 WebKit Commit Bot 2013-10-15 09:38:12 PDT 
All reviewed patches have been landed.  Closing bug.