Bug 122827 - FileIconLoader should not be ref-counted.
Summary: FileIconLoader should not be ref-counted.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-15 05:15 PDT by Andreas Kling
Modified: 2013-10-15 06:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.24 KB, patch)
2013-10-15 05:20 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-15 05:15:58 PDT
Yeah.
Comment 1 Andreas Kling 2013-10-15 05:20:46 PDT
Created attachment 214249 [details]
Patch
Comment 2 Antti Koivisto 2013-10-15 05:39:50 PDT
Comment on attachment 214249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214249&action=review

> Source/WebCore/html/FileInputType.cpp:349
> +    m_fileIconLoader = std::unique_ptr<FileIconLoader>(new FileIconLoader(*this));

make_unique?
Comment 3 Andreas Kling 2013-10-15 06:00:54 PDT
Committed r157449: <http://trac.webkit.org/changeset/157449>