Bug 122814 - Expose -[WebPluginPackage bundle] as SPI
Summary: Expose -[WebPluginPackage bundle] as SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-14 22:53 PDT by Andy Estes
Modified: 2013-10-15 13:28 PDT (History)
1 user (show)

See Also:


Attachments
Patch (18.98 KB, patch)
2013-10-14 23:00 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (7.50 KB, patch)
2013-10-15 13:20 PDT, Andy Estes
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-10-14 22:53:14 PDT
Expose -[WebPluginPackage bundle] as SPI
Comment 1 Andy Estes 2013-10-14 23:00:45 PDT
Created attachment 214234 [details]
Patch
Comment 2 Andy Estes 2013-10-15 13:20:23 PDT
Created attachment 214296 [details]
Patch
Comment 3 WebKit Commit Bot 2013-10-15 13:22:22 PDT
Attachment 214296 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/WebPluginPackage.mm', u'Source/WebKit/mac/Plugins/WebPluginPackagePrivate.h']" exit_code: 1
Source/WebKit/mac/Plugins/WebPluginPackagePrivate.h:28:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andy Estes 2013-10-15 13:28:10 PDT
Committed r157464: <http://trac.webkit.org/changeset/157464>