Bug 122808 - didNotifySubtreeInsertions shouldn't be on Node since it's only implemented by HTMLFrameElementBase
Summary: didNotifySubtreeInsertions shouldn't be on Node since it's only implemented b...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-14 20:34 PDT by Ryosuke Niwa
Modified: 2022-08-20 00:03 PDT (History)
8 users (show)

See Also:

Attachments
Work in progress (4.17 KB, patch)
2013-10-14 21:05 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-14 20:34:41 PDT 
The only class that implements didNotifySubtreeInsertions is Node and HTMLFrameElementBase.
We shouldn't even have this function on Node.

Simply check whether a given node is a HTMLFrameElementBase or not when we're constructing m_postInsertionNotificationTargets.
Comment 1 Ryosuke Niwa 2013-10-14 20:34:53 PDT 
This change was inspired by https://chromium.googlesource.com/chromium/blink/+/390c8633df7ead11d6440788b5b269126f171c37
Comment 2 Radar WebKit Bug Importer 2013-10-14 20:45:12 PDT 
<rdar://problem/15228077>
Comment 3 Ryosuke Niwa 2013-10-14 20:53:41 PDT 
Nm... this code is already optimized by having insertedInto return InsertionNotificationRequest. I guess we're not paying any extra cost here.
Comment 4 Ryosuke Niwa 2013-10-14 21:05:34 PDT 
Created attachment 214229 [details]
Work in progress
Comment 5 Ahmad Saleem 2022-08-19 23:49:18 PDT 
rniwa@webkit.org - Is something needed now or we can mark this as "RESOLVED WONTFIX"? Thanks!
Comment 6 Ryosuke Niwa 2022-08-20 00:03:24 PDT 
This is won't fix at this point.