Bug 122796 - Fix code comment in nativeForGenerator() about ARM64 calling convention
Summary: Fix code comment in nativeForGenerator() about ARM64 calling convention
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 122762
  Show dependency treegraph
Reported: 2013-10-14 17:52 PDT by Daniel Bates
Modified: 2019-05-02 16:19 PDT (History)
6 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-10-14 17:52:44 PDT
As remarked by Oliver Hunt in bug #122762, comment 15, the following code comment in function nativeForGenerator() in file Source/JavaScriptCore/jit/ThunkGenerators.cpp incorrectly describes the ARM64 calling convention:

// Calling convention: f(edi, esi, edx, ecx, ...);
Comment 1 Daniel Bates 2013-10-14 17:56:00 PDT
Can someone save me some time and let me know what the correct calling convention for ARM64 is? Then I can update the comment in the patch for bug #122762. Otherwise, when I have a moment I'll look to fix up this comment.
Comment 2 Filip Pizlo 2013-10-15 11:58:32 PDT
The best place to look for the calling convention is GPRInfo.h.  Look for argumentGPR0, argumentGPR1, etc.
Comment 4 Stellamaxwell 2018-08-17 03:17:52 PDT
The nativeForGenerator() this fix is making ready for transmitting javascript direction if conceivable. To do that, we have to decide javascript direction is upheld in the given CPU. We include a capacity nativeForGenerator(), which is capable to gather. CPU highlights if important in Linux, we can utilize an assistant vector to get the data without parsing nativeForGenerator(). https://www.courseworkempire.co.uk