NEW 122796
Fix code comment in nativeForGenerator() about ARM64 calling convention 
https://bugs.webkit.org/show_bug.cgi?id=122796
Summary Fix code comment in nativeForGenerator() about ARM64 calling convention
Daniel Bates
Reported 2013-10-14 17:52:44 PDT
As remarked by Oliver Hunt in bug #122762, comment 15, the following code comment in function nativeForGenerator() in file Source/JavaScriptCore/jit/ThunkGenerators.cpp incorrectly describes the ARM64 calling convention: // Calling convention: f(edi, esi, edx, ecx, ...);
Attachments
Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-10-14 17:56:00 PDT
Can someone save me some time and let me know what the correct calling convention for ARM64 is? Then I can update the comment in the patch for bug #122762. Otherwise, when I have a moment I'll look to fix up this comment.
Filip Pizlo
Comment 2 2013-10-15 11:58:32 PDT
The best place to look for the calling convention is GPRInfo.h. Look for argumentGPR0, argumentGPR1, etc.
Stellamaxwell
Comment 4 2018-08-17 03:17:52 PDT
The nativeForGenerator() this fix is making ready for transmitting javascript direction if conceivable. To do that, we have to decide javascript direction is upheld in the given CPU. We include a capacity nativeForGenerator(), which is capable to gather. CPU highlights if important in Linux, we can utilize an assistant vector to get the data without parsing nativeForGenerator(). https://www.courseworkempire.co.uk
Note You need to log in before you can comment on or make changes to this bug.