Bug 122790 - Windows XP stack and heap sizes should be unspecified, not 0
Summary: Windows XP stack and heap sizes should be unspecified, not 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-14 16:33 PDT by Alex Christensen
Modified: 2013-10-17 15:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2013-10-14 16:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (1.57 KB, patch)
2013-10-17 15:10 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-10-14 16:33:46 PDT 
The stack sizes of 0 was causing WinCairo to crash 100% of the time immediately upon opening WinLauncher because there were problems with making new threads with pthreadVC2.dll.  The fix requires this and a change to WinCairoRequirements which Anthony already emailed to Brent.
Comment 1 Alex Christensen 2013-10-14 16:36:22 PDT 
Created attachment 214208 [details]
Patch
Comment 2 Roger Fong 2013-10-17 15:07:58 PDT 
Can you say in the ChangeLog that the fix is for XP in general? (Since it fixes AppleWin XP too)

Unofficial r+
Comment 3 Alex Christensen 2013-10-17 15:10:18 PDT 
Created attachment 214518 [details]
patch
Comment 4 Geoffrey Garen 2013-10-17 15:19:55 PDT 
Comment on attachment 214518 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2013-10-17 15:45:26 PDT 
Comment on attachment 214518 [details]
patch

Clearing flags on attachment: 214518

Committed r157608: <http://trac.webkit.org/changeset/157608>
Comment 6 WebKit Commit Bot 2013-10-17 15:45:27 PDT 
All reviewed patches have been landed.  Closing bug.