Bug 122774 - Windows popup menu does not reselect last selected index when clicking on a disabled option
Summary: Windows popup menu does not reselect last selected index when clicking on a d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 18358 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-10-14 12:52 PDT by Roger Fong
Modified: 2013-11-02 11:05 PDT (History)
4 users (show)

See Also:


Attachments
patch (3.79 KB, patch)
2013-10-14 13:04 PDT, Roger Fong
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-10-14 12:52:21 PDT
<rdar://problem/6138855>

Right now we set the selected item to the last focused element (which is the last element the user focused on via either mouse or keyboard interaction).
It should just go to the previously selected item if we click on a disabled option (this is to match behavior on mac)
Comment 1 Roger Fong 2013-10-14 13:04:43 PDT
Created attachment 214183 [details]
patch
Comment 2 Brent Fulgham 2013-10-14 13:24:58 PDT
Comment on attachment 214183 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214183&action=review

Looks good to me. I wonder if we will mess up WINCE at all with the movement of the "setFocusedIndex" logic to inside the #if !OS(WINCE) block.

> Source/WebCore/platform/win/PopupMenuWin.cpp:167
> +    }

Do you think this block is needed by WINCE?
Comment 3 Roger Fong 2013-10-14 14:15:52 PDT
Oops. Didn't notice that I had put that there.
I'll move it out though just to be safe.
Comment 4 Roger Fong 2013-10-14 15:52:44 PDT
Committed: http://trac.webkit.org/changeset/157423
Comment 5 mitz 2013-11-02 11:05:14 PDT
*** Bug 18358 has been marked as a duplicate of this bug. ***