Bug 122773 – Add a PlatformCALayer subclass that proxies its property changes across the process boundary

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tim Horton]

Instead of having PlatformLayers in the Web process, have a PlatformCALayer subclass (PlatformCALayerRemote?) that keeps track of property changes and funnels them over to the UI process, where we will have PlatformLayers.

[Tim Horton]

Created attachment 214313 [details]
patch

[WebKit Commit Bot]

Attachment 214313 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/graphics/GraphicsLayer.h', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp', u'Source/WebKit2/Shared/WebCoreArgumentCoders.h', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.h', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm', u'Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteGraphicsLayer.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteGraphicsLayer.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm']" exit_code: 1
Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h:148:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/WebPageProxy.h:394:  The parameter name "rootLayer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:30:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 3 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Simon wants a typedef for the layer ID

[EFL EWS Bot]

Comment on attachment 214313 [details]
patch

Attachment 214313 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3384087

[Anders Carlsson]

Comment on attachment 214313 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214313&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:85
> +        const RemoteLayerTreeTransaction::LayerProperties& properties = changedLayer.value;

Can use const auto& here.

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:116
> +            NSMutableArray *children = [[NSMutableArray alloc] init];

I believe you’re leaking this array here. Also, I think you can initWithCapacity.

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:132
> +        layer.get().style = @{ @"actions" : nullActionsDictionary() };

I think you should use [layer setStyle:] here.

> Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h:61
> +

Extra newline here.

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:140
> +

Extra newline.

[Tim Horton]

http://trac.webkit.org/changeset/157478