Bug 122765 - Add FTL support for LogicalNot(string)
Summary: Add FTL support for LogicalNot(string)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-14 11:10 PDT by Nadav Rotem
Modified: 2013-10-14 16:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.23 KB, patch)
2013-10-14 11:11 PDT, Nadav Rotem 		no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2013-10-14 14:27 PDT, Nadav Rotem 		fpizlo: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nadav Rotem 2013-10-14 11:10:25 PDT 
Add FTL support for LogicalNot(string)
Comment 1 Nadav Rotem 2013-10-14 11:11:32 PDT 
Created attachment 214169 [details]
Patch
Comment 2 Filip Pizlo 2013-10-14 14:17:17 PDT 
Comment on attachment 214169 [details]
Patch

Why isn't the String case handled in boolify()?  The point of boolify() is that Branch and LogicalNot handle the same inputs.
Comment 3 Nadav Rotem 2013-10-14 14:27:48 PDT 
Created attachment 214187 [details]
Patch
Comment 4 WebKit Commit Bot 2013-10-14 15:08:08 PDT 
Comment on attachment 214187 [details]
Patch

Rejecting attachment 214187 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 214187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   8b2f263..68083b5  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 157423 = 8b2f263c03d7a0ea8b8ac23380bc631fab14f5ec
r157424 = 68083b5599c1cfca0f6963f8256eeaadc01fc70e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/3952908
Comment 5 Nadav Rotem 2013-10-14 15:18:32 PDT 
This error looks unrelated to the patch:

Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114.
error: git-svn died of signal 11
Comment 6 WebKit Commit Bot 2013-10-14 15:35:56 PDT 
Comment on attachment 214187 [details]
Patch

Rejecting attachment 214187 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 214187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
t.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114.
error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/3885941
Comment 7 Mark Lam 2013-10-14 16:29:53 PDT 
On behalf of Nadav, landed in r157429: <http://trac.webkit.org/r157429>.