Bug 122749 - [EFL] Buildfix after r157393
Summary: [EFL] Buildfix after r157393
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-14 05:16 PDT by Krzysztof Czech
Modified: 2013-10-14 06:38 PDT (History)
10 users (show)

See Also:


Attachments
Patch (1.23 KB, patch)
2013-10-14 05:19 PDT, Krzysztof Czech
kling: review-
Details | Formatted Diff | Diff
Patch (1.25 KB, patch)
2013-10-14 06:12 PDT, Krzysztof Czech
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-10-14 05:16:51 PDT
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/css/CSSCalculationValue.cpp: In function 'bool WebCore::hasDoubleValue(WebCore::CSSPrimitiveValue::UnitTypes)':
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/css/CSSCalculationValue.cpp:84:12: error: enumeration value 'CSS_FR' not handled in switch [-Werror=switch]
Comment 1 Krzysztof Czech 2013-10-14 05:19:54 PDT
Created attachment 214144 [details]
Patch
Comment 2 Andreas Kling 2013-10-14 05:22:50 PDT
Comment on attachment 214144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214144&action=review

> Source/WebCore/css/CSSCalculationValue.cpp:114
> +    case CSSPrimitiveValue::CSS_FR:

Is this correct? It seems that CSS_FR would be represented by a double value internally.
Comment 3 Andreas Kling 2013-10-14 05:45:11 PDT
Comment on attachment 214144 [details]
Patch

hasDoubleValue() should return true for CSS_FR.
Comment 4 Krzysztof Czech 2013-10-14 06:12:37 PDT
Created attachment 214147 [details]
Patch
Comment 5 Krzysztof Czech 2013-10-14 06:15:06 PDT
(In reply to comment #3)
> (From update of attachment 214144 [details])
> hasDoubleValue() should return true for CSS_FR.
Yes, you are right. Thanks.
Comment 6 Anders Carlsson 2013-10-14 06:38:21 PDT
Comment on attachment 214147 [details]
Patch

Clearing flags on attachment: 214147

Committed r157397: <http://trac.webkit.org/changeset/157397>
Comment 7 Anders Carlsson 2013-10-14 06:38:25 PDT
All reviewed patches have been landed.  Closing bug.