Bug 122732 - build.webkit.org/dashboard incorrectly shows interrupted builds as green
Summary: build.webkit.org/dashboard incorrectly shows interrupted builds as green
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-13 14:08 PDT by Alexey Proskuryakov
Modified: 2013-10-13 22:00 PDT (History)
2 users (show)

See Also:


Attachments
screenshot (19.84 KB, image/png)
2013-10-13 14:08 PDT, Alexey Proskuryakov
no flags Details
JSON results (11.29 KB, application/json)
2013-10-13 14:46 PDT, Alexey Proskuryakov
no flags Details
proposed fix (4.67 KB, patch)
2013-10-13 15:42 PDT, Alexey Proskuryakov
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-13 14:08:04 PDT
Created attachment 214111 [details]
screenshot

<http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10751> was "Retry exception slave lost", but the dashboard shows it green.
Comment 1 Alexey Proskuryakov 2013-10-13 14:46:16 PDT
Created attachment 214113 [details]
JSON results
Comment 2 Alexey Proskuryakov 2013-10-13 15:42:25 PDT
Created attachment 214118 [details]
proposed fix
Comment 3 WebKit Commit Bot 2013-10-13 15:44:56 PDT
Attachment 214118 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js', u'Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js', u'Tools/ChangeLog']" exit_code: 1
Tools/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alexey Proskuryakov 2013-10-13 22:00:47 PDT
Committed <http://trac.webkit.org/r157386>.