Bug 122728 - CTTE: RenderSlider always has an HTMLInputElement.
Summary: CTTE: RenderSlider always has an HTMLInputElement.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-13 07:28 PDT by Andreas Kling
Modified: 2013-10-13 08:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2013-10-13 07:28 PDT, Andreas Kling 		andersca: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (4.73 KB, patch)
2013-10-13 07:34 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-13 07:28:13 PDT 
CTTE: RenderSlider always has an HTMLInputElement.
Comment 1 Andreas Kling 2013-10-13 07:28:40 PDT 
Created attachment 214101 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-13 07:32:02 PDT 
Comment on attachment 214101 [details]
Patch

Attachment 214101 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3776691
Comment 3 EFL EWS Bot 2013-10-13 07:33:04 PDT 
Comment on attachment 214101 [details]
Patch

Attachment 214101 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3403737
Comment 4 Andreas Kling 2013-10-13 07:34:35 PDT 
Created attachment 214102 [details]
Patch
Comment 5 WebKit Commit Bot 2013-10-13 08:02:32 PDT 
Comment on attachment 214102 [details]
Patch

Clearing flags on attachment: 214102

Committed r157370: <http://trac.webkit.org/changeset/157370>
Comment 6 WebKit Commit Bot 2013-10-13 08:02:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Antti Koivisto 2013-10-13 08:07:53 PDT 
Comment on attachment 214102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214102&action=review

> Source/WebCore/rendering/RenderSlider.cpp:65
> +    return toHTMLInputElement(nodeForNonAnonymous());

For completeness we should have elementForNonAnonymous. RenderElement subclasses should not have access to Nodes at all.