Bug 122717 - Rewrite Document::body and Document::head in modern style, way clearer and shorter
Summary: Rewrite Document::body and Document::head in modern style, way clearer and sh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on: 122733
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-13 00:00 PDT by Darin Adler
Modified: 2019-02-06 09:02 PST (History)
13 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2013-10-13 00:01 PDT, Darin Adler 		kling: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-10-13 00:00:42 PDT 
Rewrite Document::body and Document::head in modern style, way clearer and shorter
Comment 1 Darin Adler 2013-10-13 00:01:10 PDT 
Created attachment 214087 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-13 00:05:36 PDT 
Comment on attachment 214087 [details]
Patch

Attachment 214087 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3867590
Comment 3 EFL EWS Bot 2013-10-13 00:09:02 PDT 
Comment on attachment 214087 [details]
Patch

Attachment 214087 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3953510
Comment 4 Build Bot 2013-10-13 00:29:10 PDT 
Comment on attachment 214087 [details]
Patch

Attachment 214087 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3951470
Comment 5 Build Bot 2013-10-13 00:39:09 PDT 
Comment on attachment 214087 [details]
Patch

Attachment 214087 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3953516
Comment 6 Build Bot 2013-10-13 00:45:03 PDT 
Comment on attachment 214087 [details]
Patch

Attachment 214087 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3952496
Comment 7 kov's GTK+ EWS bot 2013-10-13 01:15:55 PDT 
Comment on attachment 214087 [details]
Patch

Attachment 214087 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/3403655
Comment 8 Darin Adler 2013-10-13 12:19:47 PDT 
Committed r157381: <http://trac.webkit.org/changeset/157381>
Comment 9 Alexey Proskuryakov 2013-10-13 14:11:56 PDT 
This broke a lot of tests, I'm going to roll out.

<http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10752>
Comment 10 WebKit Commit Bot 2013-10-13 14:14:48 PDT 
Re-opened since this is blocked by bug 122733
Comment 11 Alexey Proskuryakov 2013-10-13 14:15:35 PDT 
Andreas is going to see if he can fix real quick.
Comment 12 Andreas Kling 2013-10-13 15:09:58 PDT 
(In reply to comment #11)
> Andreas is going to see if he can fix real quick.

https://trac.webkit.org/r157383
https://trac.webkit.org/r157384

That was a silly bug, I should have caught it in review.
Comment 13 Darin Adler 2013-10-13 15:46:25 PDT 
I don’t know why I didn’t test. I could have sworn I did.

I don’t get why childrenOfType takes a pointer, but doesn’t handle null. We should fix that.
Comment 14 Darin Adler 2013-10-13 15:46:35 PDT 
By making it take a reference.
Comment 15 Lucas Forschler 2019-02-06 09:02:56 PST 
Mass moving XML DOM bugs to the "DOM" Component.